Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge queue: embarking main (511f079), #3507 and #3617 together #3623

Closed
wants to merge 10 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 13, 2024

✨ Pull request #3507 which was ahead in the queue has been dequeued. The pull request #3617 has been re-embarked. ✨

Branch main (511f079), #3507 and #3617 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #3617.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue main-queue for merge:

  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (0)
    • check-skipped=test-e2e (0)
    • check-success=test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (1)
    • check-skipped=test-e2e (1)
    • check-success=test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (2)
    • check-skipped=test-e2e (2)
    • check-success=test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (3)
    • check-skipped=test-e2e (3)
    • check-success=test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-neutral=test-e2e (4)
    • check-skipped=test-e2e (4)
    • check-success=test-e2e (4)
  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-neutral=Mergify Merge Protections
    • check-skipped=Mergify Merge Protections
    • check-success=Mergify Merge Protections
  • any of [🛡 GitHub branch protection]:
    • check-success=check-benchmarks
    • check-neutral=check-benchmarks
    • check-skipped=check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success=check-packages
    • check-neutral=check-packages
    • check-skipped=check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success=build-binaries
    • check-neutral=build-binaries
    • check-skipped=build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-neutral=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-skipped=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
  • any of [🛡 GitHub branch protection]:
    • check-success=lints
    • check-neutral=lints
    • check-skipped=lints
  • any of [🛡 GitHub branch protection]:
    • check-success=test-unit
    • check-neutral=test-unit
    • check-skipped=test-unit
  • any of [🛡 GitHub branch protection]:
    • check-success=test-integration
    • check-neutral=test-integration
    • check-skipped=test-integration
  • any of [🛡 GitHub branch protection]:
    • check-success=test-wasm
    • check-neutral=test-wasm
    • check-skipped=test-wasm

Required conditions to stay in the queue:

  • #approved-reviews-by >= 1
  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • base = main
  • any of [🛡 GitHub branch protection]:
    • check-neutral=Mergify Merge Protections
    • check-skipped=Mergify Merge Protections
    • check-success=Mergify Merge Protections
  • any of [🛡 GitHub branch protection]:
    • check-success=check-benchmarks
    • check-neutral=check-benchmarks
    • check-skipped=check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success=check-packages
    • check-neutral=check-packages
    • check-skipped=check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success=build-binaries
    • check-neutral=build-binaries
    • check-skipped=build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped=build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-neutral=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
    • check-skipped=build-wasm (wasm, build-wasm-scripts, wasm/tx_*.wasm wasm/vp_*.wasm wasm/checksums.json )
  • any of [🛡 GitHub branch protection]:
    • check-success=lints
    • check-neutral=lints
    • check-skipped=lints
  • any of [🛡 GitHub branch protection]:
    • check-success=test-unit
    • check-neutral=test-unit
    • check-skipped=test-unit
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (0)
    • check-neutral=test-e2e (0)
    • check-skipped=test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (1)
    • check-neutral=test-e2e (1)
    • check-skipped=test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (2)
    • check-neutral=test-e2e (2)
    • check-skipped=test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (3)
    • check-neutral=test-e2e (3)
    • check-skipped=test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-e2e (4)
    • check-neutral=test-e2e (4)
    • check-skipped=test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-success=test-integration
    • check-neutral=test-integration
    • check-skipped=test-integration
  • any of [🛡 GitHub branch protection]:
    • check-success=test-wasm
    • check-neutral=test-wasm
    • check-skipped=test-wasm
---
previous_failed_batches: []
pull_requests:
  - number: 3617
...

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 61.25%. Comparing base (511f079) to head (cd6bd56).

Files Patch % Lines
crates/sdk/src/signing.rs 0.00% 30 Missing ⚠️
crates/governance/src/storage/mod.rs 0.00% 11 Missing ⚠️
crates/node/src/shell/governance.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3623      +/-   ##
==========================================
- Coverage   61.27%   61.25%   -0.02%     
==========================================
  Files         312      312              
  Lines      101338   101358      +20     
==========================================
- Hits        62092    62090       -2     
- Misses      39246    39268      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot closed this Aug 13, 2024
@mergify mergify bot deleted the mergify/merge-queue/b2961b2048 branch August 13, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants